Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper support of angular 14+ (Not working in angular 16 due to absent ngcc) #224

Open
pumano opened this issue Oct 9, 2022 · 7 comments
Labels
Comp: Core Core functionality of ngqp Priority: Medium Users can work without this for now, but this should be fixed soon-ish Type: Feature If you want to add something that doesn't exist yet

Comments

@pumano
Copy link

pumano commented Oct 9, 2022

Angular ngcc processing ngqp as view engine:

Processing legacy "View Engine" libraries:
- @ngqp/core [fesm2015/esm2015] (https://github.com/TNG/ngqp.git)
- @ngqp/core [esm2015/esm2015] (https://github.com/TNG/ngqp.git)
- @ngqp/core [main/umd] (https://github.com/TNG/ngqp.git)

What's your idea?

Save time for ngcc processing
Describe the solution you'd like

Could you please update dependencies to 14 angular in package json and ng-packagr and after fix all stuff update your lib (yes it's breaking change). Because it should be compiled properly against ivy, and also check parameter compilationMode: 'partial' for publishing.
Additional context

@pumano pumano added Status: Needs Triage We need to properly tag this issue Type: Feature If you want to add something that doesn't exist yet labels Oct 9, 2022
@Airblader Airblader added Comp: Core Core functionality of ngqp Priority: Medium Users can work without this for now, but this should be fixed soon-ish and removed Status: Needs Triage We need to properly tag this issue labels Oct 9, 2022
@Airblader
Copy link
Collaborator

I definitely wouldn't mind this. Are you interested in submitting a PR? I probably won't have time to do this myself, but happy to support.

@pumano
Copy link
Author

pumano commented Oct 9, 2022

@Airblader ok, I will prepare PR soon, but can't test it before release, I just check for build properly, and after you release, I can test it

@pumano
Copy link
Author

pumano commented Nov 4, 2022

@Airblader I stuck in your demo app, while trying to update project to 14 angular due to using raw-loader.

Webpack 5 don't have that loader, and have own 'asset/source' type for that. Currently it possible only via custom webpack config. Details: angular/angular-cli#21305

Can I only prepare PR with library change without changing demo website?

@Airblader
Copy link
Collaborator

Yes, I'm aware of that issue, which is why I never updated the demo either. I'm OK with excluding the demo here, but we'll need some kind of verification that it does work.

pumano added a commit to pumano/ngqp that referenced this issue Nov 4, 2022
pumano added a commit to pumano/ngqp that referenced this issue Nov 6, 2022
closes TNG#224

Revert "chore: support ivy based partial compilation for @ngqp/core"

This reverts commit 979f038.

chore: fix
@pumano
Copy link
Author

pumano commented Nov 6, 2022

It's hard to get, due to demo project contains 'raw-loader' webpack plugin, but angular 14 use webpack 5 where raw-loader does not exist, and need to change strategy of loading .ts files as text.

@pumano pumano closed this as completed Nov 6, 2022
@pumano
Copy link
Author

pumano commented Apr 6, 2023

looks like angular 16 remove ngcc util and library does not work more.

This likely means that the library (@ngqp/core) which declares QueryParamModule is not compatible with Angular Ivy.
Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to
see if the library is expected to be compatible with Ivy.

@pumano pumano reopened this Apr 6, 2023
@pumano pumano changed the title Proper support of angular 14 Proper support of angular 14+ (Not working in angular 16 due to absent ngcc) Apr 6, 2023
@pumano
Copy link
Author

pumano commented Apr 6, 2023

commit: 979f038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp: Core Core functionality of ngqp Priority: Medium Users can work without this for now, but this should be fixed soon-ish Type: Feature If you want to add something that doesn't exist yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants