-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper support of angular 14+ (Not working in angular 16 due to absent ngcc) #224
Comments
I definitely wouldn't mind this. Are you interested in submitting a PR? I probably won't have time to do this myself, but happy to support. |
@Airblader ok, I will prepare PR soon, but can't test it before release, I just check for build properly, and after you release, I can test it |
@Airblader I stuck in your demo app, while trying to update project to 14 angular due to using Webpack 5 don't have that loader, and have own Can I only prepare PR with library change without changing demo website? |
Yes, I'm aware of that issue, which is why I never updated the demo either. I'm OK with excluding the demo here, but we'll need some kind of verification that it does work. |
It's hard to get, due to demo project contains 'raw-loader' webpack plugin, but angular 14 use webpack 5 where raw-loader does not exist, and need to change strategy of loading |
looks like angular 16 remove ngcc util and library does not work more.
|
commit: 979f038 |
Angular ngcc processing ngqp as view engine:
What's your idea?
Save time for ngcc processing
Describe the solution you'd like
Could you please update dependencies to 14 angular in package json and ng-packagr and after fix all stuff update your lib (yes it's breaking change). Because it should be compiled properly against ivy, and also check parameter
compilationMode: 'partial'
for publishing.Additional context
The text was updated successfully, but these errors were encountered: