Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor monaco editor usage #127

Open
njustus opened this issue Oct 9, 2019 · 0 comments
Open

Refactor monaco editor usage #127

njustus opened this issue Oct 9, 2019 · 0 comments
Labels
ui User Interface/frontend related

Comments

@njustus
Copy link
Member

njustus commented Oct 9, 2019

The current monaco editor isn't ReactJS friendly. It's a hack to avoid polluting the website with many editor instances. React components do have a lifecycle. There are methods that are only called once on instantiation. Use these methods instead of the static hack.
@njustus njustus added the ui User Interface/frontend related label Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui User Interface/frontend related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@njustus