Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Interval" parameter is called "startTime" after transfer to simulate page #106

Open
CSchoel opened this issue Jul 23, 2019 · 3 comments
Open
Labels
good first issue Good for newcomers ui User Interface/frontend related

Comments

@CSchoel
Copy link
Member

CSchoel commented Jul 23, 2019

Transferring this annotation

annotation(
  experiment(StartTime = 0, StopTime = 50, Tolerance = 1e-6, Interval = 0.002),
  __OpenModelica_simulationFlags(lv = "LOG_STATS", s = "dassl")
);

to the "simulate" page yields these settings:

  • startTime = 0 (correct)
  • endTime = 50 (correct)
  • tolerance = 0.000001 (correct)
  • startTime = 0.002 (incorrect, should be "interval", not "startTime")
@CSchoel
Copy link
Member Author

CSchoel commented Jul 23, 2019

I just realized that "interval" is called "stepSize" in webmodelica. To be more general we should stick to the naming conventions of the modelica specification (page 234) and only use the terminology of OpenModelica for OpenModelica-specific parameters.

@njustus njustus added the ui User Interface/frontend related label Aug 2, 2019
@njustus
Copy link
Member

njustus commented Aug 2, 2019

You are trying to tell me to rename stepSize into interval? Or should i translate interval into stepSize when switching to simulate?

@CSchoel
Copy link
Member Author

CSchoel commented Aug 17, 2020

To sum it up shortly, we need the following changes:

  • Rename stepSize to interval in the UI to conform to the Modelica specification and to keep a consistent terminology.
  • Correctly select the interval parameter in the simulation UI instead of a second "startTime" entry, when the model has an experiment() annotation that sets the Interval parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ui User Interface/frontend related
Projects
None yet
Development

No branches or pull requests

2 participants