Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support synchronous execution in "abaco run" #24

Open
mwvaughn opened this issue Aug 7, 2019 · 2 comments
Open

Support synchronous execution in "abaco run" #24

mwvaughn opened this issue Aug 7, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request test please Need help validating a feature or fix
Milestone

Comments

@mwvaughn
Copy link

mwvaughn commented Aug 7, 2019

As of Abaco 1.3.0, Abaco has a new synchronous execution mode, where a POST to an actor's mailbox will block until a response is received or timeout occurs. The result of the execution is returned as the body of the response. If bytes have been sent to the actor's /result endpoint, those bytes are returned. If not, the execution logs are returned.

Support this in abaco run as follows:

  1. Add an -x option that specifies synchronous execution
  2. Revise the message sending and response code to expect raw results in sync mode, no matter what the value of -v (verbose) is.
@mwvaughn mwvaughn added the enhancement New feature or request label Aug 7, 2019
@mwvaughn mwvaughn added this to the v1.3.0 milestone Aug 7, 2019
@mwvaughn mwvaughn self-assigned this Aug 7, 2019
@mwvaughn
Copy link
Author

mwvaughn commented Aug 7, 2019

Completed and tested pretty extensively.

@mwvaughn mwvaughn closed this as completed Aug 7, 2019
@mwvaughn mwvaughn reopened this Aug 13, 2019
@mwvaughn
Copy link
Author

Reopening for testing

@mwvaughn mwvaughn added the test please Need help validating a feature or fix label Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test please Need help validating a feature or fix
Projects
None yet
Development

No branches or pull requests

1 participant