Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ISkill.CalculateDifficulty() implementations have side effects #5

Open
Syriiin opened this issue Nov 16, 2018 · 0 comments
Open
Assignees

Comments

@Syriiin
Copy link
Owner

Syriiin commented Nov 16, 2018

Some ISkill.CalculateDifficulty() implementations have side effects which would cause a different result to return if called a second time.

eg. Volatility recovery in DimensionalSkill.CalculateEnergyExertion() (which is called from PhysicalSkill.CalculateDifficulty())

// Recover
_snapForceVolatility *= 1 - ForceVolatilityRecovery(_deltaTime);
_actualForceVolatility *= 1 - ForceVolatilityRecovery(_deltaTime);

These lines with side effects should be refactored to be done within ProcessHitObject() instead

@Syriiin Syriiin self-assigned this Nov 16, 2018
@Syriiin Syriiin changed the title Some ISkills.CalculateDifficulty() implementations have side effects Some ISkill.CalculateDifficulty() implementations have side effects Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant