You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Syriiin
changed the title
Some ISkills.CalculateDifficulty() implementations have side effects
Some ISkill.CalculateDifficulty() implementations have side effects
Nov 17, 2018
Some
ISkill.CalculateDifficulty()
implementations have side effects which would cause a different result to return if called a second time.eg. Volatility recovery in
DimensionalSkill.CalculateEnergyExertion()
(which is called fromPhysicalSkill.CalculateDifficulty()
)UniCircleDifficulty/UniCircle.Difficulty/Skills/Physical/Dimensional/DimensionalSkill.cs
Lines 49 to 51 in 53a048c
These lines with side effects should be refactored to be done within
ProcessHitObject()
insteadThe text was updated successfully, but these errors were encountered: