Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential error in BaseSynthetixBridge unit test #2210

Open
Wodann opened this issue Feb 26, 2024 · 0 comments
Open

Potential error in BaseSynthetixBridge unit test #2210

Wodann opened this issue Feb 26, 2024 · 0 comments

Comments

@Wodann
Copy link

Wodann commented Feb 26, 2024

While upgrading Hardhat, we were testing our development-version of Hardhat with synthetix and noticed that there is a test failure which seems to be the result of a previous bug in Hardhat.

1) Contract: BaseSynthetixBridge (unit tests)
       when all the deps are mocked
         when the target is deployed and the proxy is set
           initiateSynthTransfer
             fails if synth is not enabled:
     AssertionError: expected 'VM Exception while processing transac…' to include 'Transaction reverted without a reason…'
      at Object.assertRevert [as revert] (test/utils/index.js:495:12)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at Context.<anonymous> (test/contracts/BaseSynthetixBridge.unit.js:207:6)

It is our understanding that the transaction should revert with a reason string, but for some reason would show up with a "reverted without a reason" error. This should be fixed in the next version of Hardhat.

If this is not the behaviour that you'd expect from Hardhat, please let us know here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant