Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When joining a room, all participants briefly jump to the beginning of the current video #402

Open
FichteFoll opened this issue Mar 14, 2021 · 6 comments

Comments

@FichteFoll
Copy link
Contributor

FichteFoll commented Mar 14, 2021

Not sure whether this is a recent development, but I noticed lately that whenever someone joins a syncplay room, the playback jumps to 0 for everyone and then back to the initial position, causing unnecessary jumps.

It would be nice if this could be prevented by only sending a seek update when some media is loaded?

[17:41:14] FichteFoll_trackma has joined the room: 'nanaone'
[17:41:14] FichteFoll_trackma updated the playlist
[17:41:14] FichteFoll updated the playlist
[17:41:15] FichteFoll_trackma jumped from 22:29 to 00:01
[17:41:15] FichteFoll_trackma is playing 'some video file' (23:40)
[17:41:16] FichteFoll_trackma jumped from 00:02 to 22:30
[17:41:16] FichteFoll_trackma has left
@Et0h
Copy link
Contributor

Et0h commented Mar 14, 2021

I'm aware of this issue but have not found it disruptive enough to try to fix it.

Changing anything in terms of the syncing code could introduce new bugs (which could be more disruptive and harder to replicate) so if it's not causing anyone major disruption then it might be better not to touch it.

Anyone who does want to try to fix it will need to do a lot of testing.

@FichteFoll
Copy link
Contributor Author

FichteFoll commented Apr 10, 2021

I have since found out that apparently this only happens with --no-gui and with files and not URLs.

I should probably also note that most of the time the jump back to 22:30 does not happen, meaning it just sets everyone to the beginning of the media.

@FichteFoll
Copy link
Contributor Author

By now, I found this issue can also be triggered by users with a GUI, but I don't know any steps for reproduction since it seems to be inconsistent. However, the jump back generally occurs, so it isn't as much of a problem as without GUI, where the jump back was missed a lot.

@edvallie
Copy link

My friends and I frequently get this bug when a new user joins syncplay in the middle of viewing. We've never had it go back to the correct location, it always needs to be manually adjusted back to where we were in the video.

@Et0h
Copy link
Contributor

Et0h commented Feb 24, 2023

My friends and I frequently get this bug when a new user joins syncplay in the middle of viewing. We've never had it go back to the correct location, it always needs to be manually adjusted back to where we were in the video.

I've not had this problem with an all-mpv grouping.

Are you all using mpv or are some of you using different media players? If other players are involved, which ones?

@selurvedu
Copy link

I've not had this problem with an all-mpv grouping.

Are you all using mpv or are some of you using different media players? If other players are involved, which ones?

@Et0h Same here, everyone is using mpv. It's apparent when wathcing something via yt-dlp. Maybe it's because the new participant doesn't have the video buffered yet, but this does not explain the cases described above with regular videos and video URLs.

We've never had it go back to the correct location, it always needs to be manually adjusted back to where we were in the video.

@edvallie Try using the "Playback -> Undo seek" menu or "/u" chat command or Shift+Backspace in mpv (this also works without syncplay as it's an mpv feature).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants