Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed sample XLSX, employ usings & var #54

Open
DickBaker opened this issue Sep 26, 2023 · 0 comments
Open

embed sample XLSX, employ usings & var #54

DickBaker opened this issue Sep 26, 2023 · 0 comments

Comments

@DickBaker
Copy link

consider this GH example

  1. opens the sample InputTemplate.xlsx in 3 folders higher [i.e. the program source directory] which is bad practice because would be wrong on deploying to PROD [like good chefs your never reveal your sauces!]. Instead I propose you mark that xls to be copied to target folder on build, so then available in target to both dev and prod
  2. uses legacy explicit type, i.e. does not reflect current "var" guideline of using implied type
  3. legacy use of .Close() does not accord with best practice to wrap disposable objects within a using block [or statement for method scope], which will protect against any exceptions
  4. I would prefer file-scoped namespace instead of legacy block-scope
  5. this GH project does not contain the necessary .gitignore file, so any unwitting PR would contain all bin/obj/debug detritus

I will submit a PR (items 1-3) for consideration by SF, but the above issue occurs elsewhere and needs fixing throughout.

DickBaker pushed a commit to DickBaker/XlsIO-Examples that referenced this issue Sep 26, 2023
DickBaker pushed a commit to DickBaker/XlsIO-Examples that referenced this issue Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant