Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer caching is broken #9

Open
stof opened this issue Jan 16, 2013 · 5 comments
Open

Composer caching is broken #9

stof opened this issue Jan 16, 2013 · 5 comments

Comments

@stof
Copy link

stof commented Jan 16, 2013

I ported the composer caching back to our bash buildback based on the old SimpleIT repo. And this allowed me to spot an issue when deploying: your cache is never used as you delete it before that.

the issue is that the composer cache is in self._bp.cache_dir+'/www/vendor' but you use self._bp.cache_dir + '/www' as temporary folder when isolating the app files

@Swop
Copy link
Owner

Swop commented Jan 17, 2013

Oh! Nice shot!
I'll will be working on that the next few days days ...

By the way, I worked on the future main concepts of module injection in a separated app... It will be merged in the buildpack soon :-)

@stof
Copy link
Author

stof commented Jan 17, 2013

great.

@stof
Copy link
Author

stof commented Jan 17, 2013

See Incenteev/heroku-buildpack-sdz@5a716ad for the way I fixed it in our buildpack

@Swop
Copy link
Owner

Swop commented Jan 17, 2013

Yeah I just tested the same thing on the buildpack in Python, but it doesn't seems to work. I'll try to work on it tomorrow.

@stof
Copy link
Author

stof commented Jan 17, 2013

well, for me, it works. Check whether you don't have another part overriding it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants