Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to customize the amount of storage when starting a session #3451

Closed
lorenzo-cavazzi opened this issue Dec 19, 2024 · 2 comments · Fixed by #3463
Closed

Allow users to customize the amount of storage when starting a session #3451

lorenzo-cavazzi opened this issue Dec 19, 2024 · 2 comments · Fixed by #3463
Assignees
@leafty
Labels
Cooldown high priority

Comments

@lorenzo-cavazzi
Copy link
Member

Currently, users can't define how much storage a session should have; it takes the default from the dropdown menu.
We should add the slider as we have it in Renku 1.0

Screenshot_20241219_122624
@leafty
Copy link
Member

leafty commented Dec 20, 2024

Adding the slider and saving the value will require to update the session launcher fields on renku-data-services. Currently, only the resource class ID is persisted for a session launcher.

We can provide a slider for the "custom launch" action and send the requested disk size for the session launch. However, that value would not be saved at the moment.

@leafty leafty mentioned this issue Dec 20, 2024
Closed
@leafty leafty self-assigned this Dec 20, 2024
@leafty
Copy link
Member

leafty commented Dec 20, 2024

Note: this is a duplicate of #3300.

leafty added a commit that referenced this issue Dec 23, 2024
@leafty
feat: configure disk storage for Renku 2.0 sessions
c3f8c6d 
Closes #3451.
@leafty leafty mentioned this issue Dec 23, 2024
Merged
leafty added a commit that referenced this issue Jan 14, 2025
@leafty
feat: configure disk storage for Renku 2.0 sessions (#3463)
88d44e7 
Closes #3451.

Add an option to configure disk storage in 3 locations:
* Add launcher
* Modify launcher's resource class
* Custom launch

**Breaking change**: requires update to `renku-data-services`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leafty leafty

Labels
Cooldown high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: configure disk storage for Renku 2.0 sessions SwissDataScienceCenter/renku-ui
2 participants
@leafty @lorenzo-cavazzi