Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the ExternalLink component #3255

Closed
lorenzo-cavazzi opened this issue Jul 25, 2024 · 1 comment
Closed

Rework the ExternalLink component #3255

lorenzo-cavazzi opened this issue Jul 25, 2024 · 1 comment
Labels

Comments

@lorenzo-cavazzi
Copy link
Member

ExternalLink should set a standard for rendering links leading outside RenkuLab in a standardized way.
We added too many properties to the current component and customized the look too much -- even having variations like <ExternalLinkButton /> that renders very differently than <ExternalLink role="button" />

We should make a new version of that and use it consistently everywhere in the Renku v2 pages, leaving the styling to the className property as we do for Link (i.e. for rendering as a small primary button, just use the required Boostrap classes).
We should agree with the design team whether we want to include a visual indication of the link leading to an external place (E.G. the Box arrow up-right bootstrap icon after the text) and apply it consistently, with an option to turn it off for exception cases but no ways to customize it (no iconAfter, iconsSize, iconSup, ...)

@lorenzo-cavazzi
Copy link
Member Author

The component is heavily used in V1, where we don't plan further changes.
We can open another issue if we plan to introduce a similar component for v2

@lorenzo-cavazzi lorenzo-cavazzi closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant