From 756da48ffa7055c1e1b44015e2fd7ffe774afe00 Mon Sep 17 00:00:00 2001
From: Chandrasekhar Ramakrishnan <ciyer@users.noreply.github.com>
Date: Tue, 27 Aug 2024 08:56:59 +0200
Subject: [PATCH] refactor: split out the save credentials section into its own
 file

---
 .../cloudStorage/AddOrEditCloudStorage.tsx    | 59 +-------------
 .../AddStorageMountSaveCredentialsInfo.tsx    | 81 +++++++++++++++++++
 2 files changed, 84 insertions(+), 56 deletions(-)
 create mode 100644 client/src/features/project/components/cloudStorage/AddStorageMountSaveCredentialsInfo.tsx

diff --git a/client/src/features/project/components/cloudStorage/AddOrEditCloudStorage.tsx b/client/src/features/project/components/cloudStorage/AddOrEditCloudStorage.tsx
index 96d72706cb..578c032664 100644
--- a/client/src/features/project/components/cloudStorage/AddOrEditCloudStorage.tsx
+++ b/client/src/features/project/components/cloudStorage/AddOrEditCloudStorage.tsx
@@ -70,6 +70,8 @@ import { ExternalLink } from "../../../../components/ExternalLinks";
 import { WarnAlert } from "../../../../components/Alert";
 import type { CloudStorageSecretGet } from "../../../../features/projectsV2/api/storagesV2.api";
 
+import AddStorageMountSaveCredentialsInfo from "./AddStorageMountSaveCredentialsInfo";
+
 import styles from "./CloudStorage.module.scss";
 
 interface AddOrEditCloudStorageProps {
@@ -1097,7 +1099,7 @@ function AddStorageOptions({
 
 // *** Add storage: page 3 of 3, with name and mount path *** //
 
-interface AddStorageMountForm {
+export interface AddStorageMountForm {
   name: string;
   mountPoint: string;
   readOnly: boolean;
@@ -1304,58 +1306,3 @@ function AddStorageMount({
     </form>
   );
 }
-
-type AddStorageMountSaveCredentialsInfoProps = {
-  control: Control<AddStorageMountForm>;
-  onFieldValueChange: (field: "saveCredentials", value: boolean) => void;
-  state: AddCloudStorageState;
-};
-
-function AddStorageMountSaveCredentialsInfo({
-  control,
-  onFieldValueChange,
-  state,
-}: AddStorageMountSaveCredentialsInfoProps) {
-  return (
-    <div className="mt-3">
-      <Label className="form-label" for="saveCredentials">
-        Save credentials
-      </Label>
-
-      <Controller
-        name="saveCredentials"
-        control={control}
-        render={({ field }) => (
-          <input
-            id="saveCredentials"
-            type="checkbox"
-            {...field}
-            className={cx("form-check-input", "ms-1")}
-            onChange={(e) => {
-              field.onChange(e);
-              onFieldValueChange("saveCredentials", e.target.checked);
-            }}
-            value=""
-            checked={state.saveCredentials}
-          />
-        )}
-        rules={{ required: true }}
-      />
-      {state.saveCredentials && (
-        <div className="mt-1">
-          <WarnAlert dismissible={false}>
-            <p className="mb-0">
-              The credentials will be stored as secrets and only be for your
-              use. Other users will have to supply their credentials to use this
-              data source.
-            </p>
-          </WarnAlert>
-        </div>
-      )}
-      <div className={cx("form-text", "text-muted")}>
-        Check this box to save credentials as secrets, so you will not have to
-        provide them again when starting a session.
-      </div>
-    </div>
-  );
-}
diff --git a/client/src/features/project/components/cloudStorage/AddStorageMountSaveCredentialsInfo.tsx b/client/src/features/project/components/cloudStorage/AddStorageMountSaveCredentialsInfo.tsx
new file mode 100644
index 0000000000..ad2b2d8c63
--- /dev/null
+++ b/client/src/features/project/components/cloudStorage/AddStorageMountSaveCredentialsInfo.tsx
@@ -0,0 +1,81 @@
+/*!
+ * Copyright 2023 - Swiss Data Science Center (SDSC)
+ * A partnership between École Polytechnique Fédérale de Lausanne (EPFL) and
+ * Eidgenössische Technische Hochschule Zürich (ETHZ).
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import cx from "classnames";
+import { Control, Controller } from "react-hook-form";
+import { Label } from "reactstrap";
+
+import { AddCloudStorageState } from "./projectCloudStorage.types";
+import { WarnAlert } from "../../../../components/Alert";
+
+import { AddStorageMountForm } from "./AddOrEditCloudStorage";
+
+type AddStorageMountSaveCredentialsInfoProps = {
+  control: Control<AddStorageMountForm>;
+  onFieldValueChange: (field: "saveCredentials", value: boolean) => void;
+  state: AddCloudStorageState;
+};
+
+export default function AddStorageMountSaveCredentialsInfo({
+  control,
+  onFieldValueChange,
+  state,
+}: AddStorageMountSaveCredentialsInfoProps) {
+  return (
+    <div className="mt-3">
+      <Label className="form-label" for="saveCredentials">
+        Save credentials
+      </Label>
+
+      <Controller
+        name="saveCredentials"
+        control={control}
+        render={({ field }) => (
+          <input
+            id="saveCredentials"
+            type="checkbox"
+            {...field}
+            className={cx("form-check-input", "ms-1")}
+            onChange={(e) => {
+              field.onChange(e);
+              onFieldValueChange("saveCredentials", e.target.checked);
+            }}
+            value=""
+            checked={state.saveCredentials}
+          />
+        )}
+        rules={{ required: true }}
+      />
+      {state.saveCredentials && (
+        <div className="mt-1">
+          <WarnAlert dismissible={false}>
+            <p className="mb-0">
+              The credentials will be stored as secrets and only be for your
+              use. Other users will have to supply their credentials to use this
+              data source.
+            </p>
+          </WarnAlert>
+        </div>
+      )}
+      <div className={cx("form-text", "text-muted")}>
+        Check this box to save credentials as secrets, so you will not have to
+        provide them again when starting a session.
+      </div>
+    </div>
+  );
+}