New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes.rb values' language #40

Open

fonji opened this issue Jan 13, 2015 · 0 comments

fonji commented Jan 13, 2015

Hello,

There's a TODO on line 36 of attributes.rb which reads

# try to get it in english if it's there. (TODO: make it configurable what the default is)

I think the easy solution would be to use I18n.locale, which defaults to :en.

Also, I think this should be applied to multivalued items.
I have a(n ugly) solution for this here with tests there.

PS: thanks for the last commits, especially the construct instead of describe, it's awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment