Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perfect rewriting isn't perfect #571

Open
ricroberts opened this issue Feb 1, 2022 · 2 comments
Open

Perfect rewriting isn't perfect #571

ricroberts opened this issue Feb 1, 2022 · 2 comments
Labels

Comments

@ricroberts
Copy link
Contributor

ricroberts commented Feb 1, 2022

If you have a values clause in a query, and we pass in a values clause e.g. in this query ...then any live graphs passed in (which have changed) will be rewritten into the draft-graphs. All ok so far.

But if the metadata graph hasn't itself changed then there wont be a draft graph for it, with a pre-rewritten version of the ?ds_graph in the db for this clause to match:

?catalog_entry pmdcat:graph ?ds_graph .

So basically rewriting isn't actually 'perfect' when spanning across live and draft graphs, if you're trying to match graph identifiers.

@ricroberts ricroberts added the bug label Feb 1, 2022
@ricroberts
Copy link
Contributor Author

ricroberts commented Feb 2, 2022

In practice this means that to do some of the stuff we need in Muttnik admin (for showing / linking to changed datasets), we might need to use the raw stardog connection and do some 'manual' rewriting.

@ricroberts
Copy link
Contributor Author

see also #618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant