Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-implement dataset diffing with SQL #338

Open
rosado opened this issue Jan 26, 2024 · 0 comments
Open

re-implement dataset diffing with SQL #338

rosado opened this issue Jan 26, 2024 · 0 comments

Comments

@rosado
Copy link
Contributor

rosado commented Jan 26, 2024

The diffing feature is broken after the move to SQL storage.

Re-implementing it shouldn't be much work. Some pointers:

  • import submitted dataset into imports::<SERIES>/<RELEASE> table
  • generate specified snapshot (which at the moment needs to be generated on demand) to diff against
  • perform the diff (using coords and synth_id) columns

This issue can be closed when issue-261.hurl test passes again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rosado