-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using native promises? #27
Comments
+1 |
@mickdekkers yessss that would be awesome! |
Thanks for the suggestion! A pull request that could demo how to improve this issue will be welcome. Please feel free to submit solutions so that we could be able to start a discussion based on that. |
Hey. I tried a little but I'd need to dig in a bit more to make this work - the issue is in the use of two Bluebird methods ...and I don't know when I'd find some time... |
@MichalCz I was able to remove bluebird in #28—which yea removes removes/changes some functionally (especially the The remaining work is to
I'm about to sign off for tonight, but any help would be greatly appreciated :D |
@munro I'll check that out. :) |
Hi,
First of all: I really like the way you wrote this bridge - I was on my way of writing the same thing on my own so this is seriously cool to see. :)
I see that your code depends on
bluebird
- which is quite heavy when compared to native promises. It has the upshot of being available anywhere, but perhaps you'd consider moving to native promises with some polyfill likeany-promise
and addbluebird
as optional dependency?I would be happy to help.
The text was updated successfully, but these errors were encountered: