-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests for installed packages #155
Comments
Thank for the initiative work. |
How would you feel about adding |
Sure. As a note, we will also need to modify the bootstrap code for the CI services so |
I'm new to the CI stuff, but shouldn't Package Control install all of the dependencies automatically? It looks like there's some pre-ST3 code in there. I wonder if it could be simplified a bit to take advantage of new features like the builtin "Install Package Control" command. |
Installation of Package Control is optional. If a user didn't install Package Control manually via |
Just to note that many packages don't include the tests in production packages delivered by Package Control. Package Control uses git to create the packages when installing. This allows developers to take advantage of the export-ignore rule in .gitattribute files (files and directories with the attribute export-ignore won’t be added to archive files. See http://git-scm.com/docs/gitattributes for details). For example: https://github.com/NeoVintageous/NeoVintageous/blob/master/.gitattributes |
Good point. In that case, I would expect UnitTesting to behave as it normally would for a package with no tests. Is there a good tutorial somewhere on setting up this sort of CI on a local machine for testing? |
I used Travis docker machine for testing. |
Currently, UnitTesting cannot run tests that are inside installed packages.
This would allow package authors to verify that their tests run when the package is installed. End users could also more easily troubleshoot their installed packages.
This is mostly because it inherits the
discover
method ofunittest.TestLoader
, which uses the filesystem directly. We could reimplementdiscover
inUnitTestingLoader
to use the resource system instead. In principle, this should work for our use case, because every test suite that UnitTesting can find should be accessible as a resource.There are also a couple of minor issues, such as the way that
unittesting.json
files are loaded.I'm working on an implementation.
The text was updated successfully, but these errors were encountered: