Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshes the wrong window #11

Open
thany opened this issue Jul 6, 2018 · 6 comments
Open

Refreshes the wrong window #11

thany opened this issue Jul 6, 2018 · 6 comments
Labels

Comments

@thany
Copy link

thany commented Jul 6, 2018

I just noticed while I have two windows of Firefox open and both visible. I press Ctrl+F9 in one window, and the active tab in the other window refreshes its CSS. That probably shouldn't happen.

It appears the workaround is to open a tab in the correct window, which will sort of "activate" it (this is probably the same behaviour as when Firefox chooses in which window to open a link clicked from an different application). Doing this will cause the plugin to choose the correct window again.

I'm on Firefox Dev 62.0b5 on Windows 10.

Just a thought: could this have caused (at least in part) issue #8?

@thany
Copy link
Author

thany commented Sep 4, 2018

If closed means fixed, when do you think you'll make a release? Thanks :)

@StoyanDimitrov
Copy link
Owner

There were several minor releases since this fix landed.

@thany
Copy link
Author

thany commented Sep 17, 2018

Well, in that case, it's not fixed I'm afraid... My addons are up-to-date and this bug is still happening.

@StoyanDimitrov
Copy link
Owner

Hm, strangely I can not reproduce in release, beta, dev ed nor nightly; with clean and main profile; add-on latest from AMO. Can you give more detailed steps to reproduce? Does it happen after browser start or after some use?

@thany
Copy link
Author

thany commented Oct 15, 2018

On my setup it only refreshes the last used tab of the window which had some kind of activity.

Here's how to reproduce (I think):
Have two Firefox windows, 1 and 2, each with a bunch of tabs open. Now go to the tab you want to refresh, and refresh it. It'll work. Now go to window number 2, do some stuff (it really doesn't matter what - uhh, F5 it or something). Go back to another application. Now click on the title bar of Firefox window number 1. Try the Ctrl+F9.

Result:
It will refresh window number 2. Wrong window, and consequently, wrong tab.

@StoyanDimitrov
Copy link
Owner

StoyanDimitrov commented Nov 13, 2018

I never successfully reproduced the issue after initial report.

Still, I discovered and published fix for a possible internal state corruption.

If 0.3.5 doesn't fix your issue as last resort I'd recommend reinstall (as in uninstall and install again) the add-on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants