Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO 1: Deps #147

Open
7 of 10 tasks
Tracked by #69
nathanjhood opened this issue Dec 12, 2024 · 1 comment · Fixed by #218
Open
7 of 10 tasks
Tracked by #69

TODO 1: Deps #147

nathanjhood opened this issue Dec 12, 2024 · 1 comment · Fixed by #218
Assignees
Labels
dependecies Changes or improvements to project dependencies and management

Comments

@nathanjhood nathanjhood self-assigned this Dec 13, 2024
@nathanjhood nathanjhood changed the title Deps TODO 1: Deps Dec 13, 2024
@nathanjhood nathanjhood added the dependecies Changes or improvements to project dependencies and management label Dec 13, 2024
@nathanjhood nathanjhood moved this to In Progress in StoneyDSP Dec 13, 2024
@nathanjhood nathanjhood linked a pull request Dec 17, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in StoneyDSP Dec 17, 2024
@nathanjhood nathanjhood moved this from Done to In Progress in StoneyDSP Dec 17, 2024
@nathanjhood nathanjhood reopened this Dec 17, 2024
@nathanjhood
Copy link
Member Author

Idea 💡 vcpkg as a submodule with Makefile support

Easy one. Before I can truly commit to my buildsystem, I need to ensure Makefile support. To accomplish this, I need to ensure that the Makefile can find my dependencies of StoneyDSP and Catch2.

In which case, I can just add vcpkg as a submodule under dep/vcpkg (I already renamed the old dir in that location to dep/vcpkg-registry to allow this), and create the following Makefile rules:

  • git submodule update init recursively
  • bootstrap vcpkg if required using it's script(s) for the purpose
  • set VCPKG_ROOT to dep/vcpkg
  • configure CMake with -DCMAKE_TOOLCHAIN_FILE..., i.e., using the CMake Presets I already wrote

This seems pretty straightforward. I'm tempted to use my own fork of vcpkg, as I could in theory add my custom ports and triplets to a branch on that fork. Alternatively, I've already got a repo in this org called vcpkg-registry which unsurprisingly somewhat resembles the filesystem registry I created in this project - I'd need to add that repo to my vcpkg configuration JSON file...

I'm slightly more in favour of keeping the registry separate from the vcpkg repo; it will be easier to maintain, and easier to share, the registry as a vcpkg config thing... i.e., with the Rack community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependecies Changes or improvements to project dependencies and management
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant