Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AGP as dependency #60

Closed
StefMa opened this issue Oct 10, 2018 · 1 comment
Closed

Remove AGP as dependency #60

StefMa opened this issue Oct 10, 2018 · 1 comment

Comments

@StefMa
Copy link
Owner

StefMa commented Oct 10, 2018 •
edited
Loading

Since we only react on the fact that the android-plugin is applied:

AndroidArtifacts/src/main/kotlin/guru/stefma/androidartifacts/plugin/AndroidArtifactsPlugin.kt

Line 28 in 4b48fe3

project.pluginManager.withPlugin(PluginIds.androidLibrary) {

there is no need to ship it as a dependency anymore.

We can simply add it as compileOnly (and maybe testRuntimeOnly) dependency...
@StefMa StefMa mentioned this issue Oct 10, 2018
Closed
@StefMa
Copy link
Owner Author

StefMa commented Oct 10, 2018

Should be done after #61

@StefMa StefMa mentioned this issue Oct 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@StefMa