Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace variable name bytecode transformer with mappings generation #11

Open
zml2008 opened this issue Jan 28, 2021 · 2 comments
Open
Labels
type: enhancement New feature or request

Comments

@zml2008
Copy link
Member

zml2008 commented Jan 28, 2021

Currently we provide variable names with bytecode transformation. This is fairly inflexible though.

Eventually, I'd like to add a way to add "mappings contributors" that receive a MappingSet and can operate on it however they want, by adding/removing/renaming mappings however they want. This would also allow us to customize official names however we want (pending output remapping support)

@kashike
Copy link
Contributor

kashike commented Jan 28, 2021

This would also allow us to customize official names however we want (pending output remapping support)

big 👎

@Zidane
Copy link
Member

Zidane commented Jan 28, 2021

@kashike

I don't see an issue with providing the support, it isn't VanillaGradle that would be exercising said support.

One use case of this would be to do parameter mapping.

@Zidane Zidane added the type: enhancement New feature or request label Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants