Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider how JS client unsubscribes from subscriptions. #188

Open
YegorUdovchenko opened this issue Oct 27, 2022 · 0 comments · Fixed by #195
Open

Reconsider how JS client unsubscribes from subscriptions. #188

YegorUdovchenko opened this issue Oct 27, 2022 · 0 comments · Fixed by #195
Assignees
Labels
Client JS Issues related to the `spine-web-client` library

Comments

@YegorUdovchenko
Copy link
Collaborator

Spine Web client for JavaScript manages the list of active subscriptions and sends “keep-up” requests to the backend periodically with some interval (20-30 seconds, not sure). When an application that uses Spine Web client unsubscribes from some subscription, a client doesn't send any requests immediately but postpones them to be sent with the next "keep-up" request. This next request usually stays unsent because a user closes an application or signs out. I propose to leave the approach of sending "keep-up" requests as is and send requests that cancel subscriptions immediately.

Also, it would be useful to expand the client's API with a parameter-less method to unsubscribe from all active subscriptions. This would come in hand when a user signs out.

@YegorUdovchenko YegorUdovchenko added the Client JS Issues related to the `spine-web-client` library label Oct 27, 2022
@armiol armiol added this to v1.9 Oct 27, 2022
@armiol armiol moved this to Todo in v1.9 Nov 7, 2022
@armiol armiol moved this from Todo to In Progress in v1.9 Jan 13, 2023
@armiol armiol self-assigned this Jan 13, 2023
@armiol armiol linked a pull request Jan 30, 2023 that will close this issue
@armiol armiol moved this from In Progress to Done in v1.9 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client JS Issues related to the `spine-web-client` library
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants