Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give code examples in Messaging concepts #14

Open
alexander-yevsyukov opened this issue Apr 5, 2019 · 2 comments
Open

Give code examples in Messaging concepts #14

alexander-yevsyukov opened this issue Apr 5, 2019 · 2 comments

Comments

@alexander-yevsyukov
Copy link
Contributor

We need to name annotations and method conventions for the message handlers such as “Command Handler” or “Event Subscriber”.

There should be also a small code snippet which displays how a method which handles this kind of messages looks like.

@meizabel
Copy link
Contributor

meizabel commented Apr 5, 2019

Use step 3 from https://spine.io/ index page.
Update the following names:
getBuilder() -> builder().
newBuilder() -> vBuilder().

@meizabel meizabel self-assigned this Apr 5, 2019
meizabel referenced this issue in meizabel/SpineEventEngine.github.io Apr 8, 2019
- Renaming getBuilder() into builder(),
- Adding a note to Command Handler and Event Subscriber concepts.
meizabel referenced this issue in meizabel/SpineEventEngine.github.io Apr 8, 2019
- Adding note contents to Command Handler and Event Subscriber concepts.
meizabel referenced this issue in meizabel/SpineEventEngine.github.io Apr 11, 2019
Fixing code example in Event Subscriber concept. Removing extra method from code sample.
alexander-yevsyukov referenced this issue in SpineEventEngine/SpineEventEngine.github.io Apr 12, 2019
Adding code example in Event Subscriber concept; renaming getBuilder() into builder to address issue #138
@armiol
Copy link
Contributor

armiol commented Apr 11, 2020

@alexander-yevsyukov you have already modified the Concepts page to include the code samples. What we have left is to describe the conventions.

@alexander-yevsyukov alexander-yevsyukov transferred this issue from SpineEventEngine/SpineEventEngine.github.io Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants