Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Clap validators to their own crate #7

Open
romac opened this issue Aug 2, 2017 · 2 comments
Open

Move Clap validators to their own crate #7

romac opened this issue Aug 2, 2017 · 2 comments

Comments

@romac
Copy link
Member

romac commented Aug 2, 2017

Or add them to https://github.com/kbknapp/clap-validators

@dtsbourg
Copy link
Member

dtsbourg commented Aug 2, 2017

Not sure it's maintained, there's only one sample validator from March 2016. clap-rs/clap-validators@61a6d06

What's the advantage of moving them to another crate ?

@romac
Copy link
Member Author

romac commented Aug 2, 2017

Not sure it's maintained, there's only one sample validator from March 2016.

Yeah I saw but since I took the idea from there, I was thinking I could contribute some of those validators to this repository. But I think you're right, as it's unmaintained we'd better build our own crate.

What's the advantage of moving them to another crate ?

Well, validators are reusable code that has nothing to do with rustysecrets, and might be useful for other projects. Also, I don't like having them in cli.rs instead of their own file, but had to do it this way because of the build-time shell completion generation (build.rs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants