Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set marginBottom on LabelValue.Value. #874

Open
shrirupa opened this issue Jun 23, 2021 · 2 comments
Open

Ability to set marginBottom on LabelValue.Value. #874

shrirupa opened this issue Jun 23, 2021 · 2 comments

Comments

@shrirupa
Copy link

shrirupa commented Jun 23, 2021

🚀 Feature request

Current Behavior

marginBottom cannot be set on LabelValue.Value. So it becomes difficult to handle mocks where the spacing is not default https://sparkpost.invisionapp.com/console/share/ZT2HZ5RVFB/607925652

Desired Behavior

marginBottom can be set on LabelValue.Value

Suggested Solution
margin props can be passed to LabelValue.Value

Who does this impact? Who is this for?

To handle mocks where the spacing is not default https://sparkpost.invisionapp.com/console/share/ZT2HZ5RVFB/607925652

@jonambas
Copy link
Contributor

jonambas commented Jul 2, 2021

LabelValue accepts margin system props. What's the use case for adding it to LabelValue.Value? Not sure I see where two values are used

@shrirupa
Copy link
Author

@jonambas as in the above mocks if the spacing being used between value and label is not the default that matchbox sets, then there isn't a way to adjust that. I think I tried using Stack but that didn't work either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants