Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noise suppression not working #499

Open
3 of 7 tasks
a0193143 opened this issue Dec 18, 2023 · 5 comments
Open
3 of 7 tasks

Noise suppression not working #499

a0193143 opened this issue Dec 18, 2023 · 5 comments
Assignees
Labels
info:upstream Issue with WebCord's depencencies / thirdparty software status:wontfix This will not be worked on type:bug Something isn't working

Comments

@a0193143
Copy link

Acknowledgements

  • I have checked that there is no other issue describing the same or
    similar problem that I currently have, regardless if it has been
    closed or open.

  • This bug affects Discord website.

  • This issue is confirmed to be reproducible when WebCord is packaged
    on at least all three latest supported Electron major releases.

  • This issue is reproducible in Chrome, Chromium or any
    Chromium-based browser, e.g Brave or Edge (please write in
    Additional Context which browser you have used if it is neither
    Chrome nor unmodified Chromium).

  • There are no fixes done to master which resolves this issue.

  • My issue describes one of the unstable and/or not fully implemented
    features.

  • I have found a workaround to mitigate or temporarily fix this issue
    in affected releases (please write it in Additional context section
    below).

Operating System / Platform

🐧️ Linux

Operating system architecture

x64 (64-bit Intel/AMD)

Electron version

28.0.0

Application version

4.6.0

Bug description

Both Krisp and Standard mode of noise suprression not working, but official Discord app is fine.
Noticed this also not work in both Chromium and Firefox.

Additional context

OS: EndeavourOS with XWayland and Wayland tried.
Hardware: Surface Go 3 (using built-in Mic)

As screenshot shows, the volume bar (noise at the moment) in official app (left) is almost 0 compared to Webcord (right).
Screenshot_20231218_182308

@a0193143 a0193143 added the type:bug Something isn't working label Dec 18, 2023
@SpacingBat3
Copy link
Owner

Noticed this also not work in both Chromium and Firefox.

Pretty much self-explainatory why.

@SpacingBat3 SpacingBat3 added info:upstream Issue with WebCord's depencencies / thirdparty software info:Wayland Issues specific to Wayland, likely caused by lack of support by Electron / Chromium. labels Dec 18, 2023
@SpacingBat3
Copy link
Owner

Also flagging this as Wayland-specific issue for now, since I have no idea if it is a quirk with Wayland or not (possibly not, but as long as nobody reports this on X11, I'll keep issues flagged like that).

@a0193143
Copy link
Author

This isn't Wayland related issue, I could reproduce on Windows as well.
Maybe Discord use specific API for noise suppression?

@ZenitH-AT
Copy link

Happens with me on X11, too. I've never experienced noise suppression working on any platform. Never worked on web version of discord so there's that.

I get around it by applying noise suppression via Pipewire.

@SpacingBat3
Copy link
Owner

SpacingBat3 commented Dec 20, 2023

Maybe Discord use specific API for noise suppression?

That is very likely to happen, in fact I suspect they're using their own (native) Node module for handling the audio. Take a note it is proprietary for now and WebCord for audio management relies only on Chromium logic (which is why bugs and limitations that occur in Chromium but not in Discord can happen with WebCord as well).

@SpacingBat3 SpacingBat3 removed the info:Wayland Issues specific to Wayland, likely caused by lack of support by Electron / Chromium. label Dec 20, 2023
@SpacingBat3 SpacingBat3 added the status:wontfix This will not be worked on label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:upstream Issue with WebCord's depencencies / thirdparty software status:wontfix This will not be worked on type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants