[Fix/#57] 다이얼로그 디자인 및 동작 수정 #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HI-JIN2
reviewed
Jan 14, 2025
Comment on lines
+57
to
+63
| child: Image.asset( | ||
| imagePath, | ||
| width: 130, | ||
| height: 130, | ||
| ), | ||
| ), | ||
| ), |
| import 'package:flutter_svg/flutter_svg.dart'; | ||
|
|
||
| /// 확인 버튼이 두개인 다이얼로그 | ||
| class SecondaryDialog extends StatelessWidget { |
There was a problem hiding this comment.
OneButtonDialog, TwoButtonDialog 요런 네이밍은 어떠할까용?
| viewModel.signOut(), | ||
| context.go(Paths.login), //라우팅 히스토리를 다 지움 | ||
| viewModel.signOut(context), | ||
| //context.go(Paths.login), //라우팅 히스토리를 다 지움 |
Comment on lines
+68
to
+87
| void _showMentorProfileDialog(BuildContext context) { | ||
| showDialog( | ||
| context: context, | ||
| builder: (BuildContext context) { | ||
| return SecondaryDialog( | ||
| title: "정말 탈퇴하시겠어요?", | ||
| subtitle: '탈퇴가 진행시 계정은 삭제되며, 계정은 복구되지 않습니다.', | ||
| imagePath: 'assets/icons/3d_img/trash.png', | ||
| firstButtonText: '취소하기', | ||
| secondButtonText: '탈퇴하기', | ||
| firstOnPressed: () => Navigator.of(context).pop(), | ||
| secondOnPressed: () { | ||
| _secureStorage.deleteAllData(); | ||
| userService.signOut(); | ||
| context.go(Paths.login); | ||
| }, | ||
| ); | ||
| }, | ||
| ); | ||
| } |
There was a problem hiding this comment.
다이알로그를 보여주는거는 뷰의 영역이라고 생각해요! 변수로 값을 넘겨주고, 다이알로그 코드는 스크린에 있는건 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
변경된 3d 이미지로 파일 추가
다이얼로그 위젯으로 변경
basic_dialog.dart
확인 버튼이 하나인 다이얼로그
secondary_dialog.dart
확인 버튼이 두개인 다이얼로그
현재 다이얼로그 동작
이렇게 세 가지 상황에서의 다이얼로그는 구현 완료하였습니다.
멘토가 멘토 소개 미입력 시 타 멘토 프로필 카드 눌렀을 때 뜨는 다이얼로그에 대해선 추후 업데이트 하겠습니다.
Screenshot
Screen_recording_20250113_204333.webm
💬 리뷰 요구사항(선택)