From 3042fb4592f78562b3c7d007d6377d93c73269c9 Mon Sep 17 00:00:00 2001 From: Dorian Burihabwa Date: Fri, 29 Nov 2024 12:06:00 +0100 Subject: [PATCH] SONARJAVA-5178 Update RSPEC before 8.7 release --- .../org/sonar/l10n/java/rules/java/S5411.html | 26 ++++++++++++++++++- sonarpedia.json | 2 +- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S5411.html b/sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S5411.html index 60b88f91231..6e1b7f8ef72 100644 --- a/sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S5411.html +++ b/sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S5411.html @@ -4,7 +4,7 @@

Why is this an issue?

boolean Values) it will throw a NullPointerException if the value is null (as defined in Java Language Specification §5.1.8 Unboxing Conversion).

It is safer to avoid such conversion altogether and handle the null value explicitly.

-

Note, however, that no issues will be raised for Booleans that have already been null-checked.

+

Note, however, that no issues will be raised for Booleans that have already been null-checked or are marked @NonNull/@NotNull.

Noncompliant code example

 Boolean b = getBoolean();
@@ -29,6 +29,30 @@ 
Compliant solution

   String test = b ? "test" : "";
 }
+

Exceptions

+

The issue is not raised if the expression is annotated @NonNull / @NotNull. This is useful if a boxed type is an +instantiation of a generic type parameter and cannot be avoided.

+
+List<Boolean> list = new ArrayList<>();
+list.add(true);
+list.add(false);
+list.forEach((@NonNull Boolean value) -> {
+  // Compliant
+  if(value) {
+    System.out.println("yes");
+  }
+});
+
+@NonNull Boolean someMethod() { /* ... */ }
+
+// Compliant
+if(someMethod()) { /* ... */ }
+
+@NonNull Boolean boxedNonNull = Boolean.TRUE;
+
+// Compliant
+if(boxedNonNull) { /* ... */ }
+

Resources