From e253a8466beca7581533ab8ddf7ffea893ae46d9 Mon Sep 17 00:00:00 2001
From: Dorian Burihabwa
 <75226315+dorian-burihabwa-sonarsource@users.noreply.github.com>
Date: Tue, 24 Oct 2023 22:54:20 +0200
Subject: [PATCH] SONARJAVA-4664 Disable deployment of java-check-test-sources
 artifacts (#4500)

* SONARJAVA-4664 Disable deployment of java-check-test-sources artifacts

Set a property that should be picked up by the artifactory plugin and prevent any attempt to synchronize from repox to Maven central at release time.

Can be tested by adding a local repository to the top-level pom and running `mvn clean deploy`.

An example of a local repository in your pom.xml
```xml
<distributionManagement>
    <repository>
        <id>local-folder</id>
        <name>Local folder to test deployment configuration</name>
        <url>file:./local-deployment</url>
    </repository>
</distributionManagement>
```
---
 java-checks-test-sources/pom.xml | 7 +------
 pom.xml                          | 8 ++++++++
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/java-checks-test-sources/pom.xml b/java-checks-test-sources/pom.xml
index 1f28ce7f29b..7f8c08678bc 100644
--- a/java-checks-test-sources/pom.xml
+++ b/java-checks-test-sources/pom.xml
@@ -18,6 +18,7 @@
     <sonar.skip>true</sonar.skip>
     <forbiddenapis.skip>true</forbiddenapis.skip>
     <skipTests>true</skipTests>
+    <maven.deploy.skip>true</maven.deploy.skip>
   </properties>
 
   <!--
@@ -951,12 +952,6 @@
           <argLine>--enable-preview</argLine>
         </configuration>
       </plugin>
-      <!--
-      We don't want to publish any artifacts from this module in artifactory or maven central.
-      Unfortunately, "org.jfrog.buildinfo : artifactory-maven-plugin" only supports maven.deploy.skip=true at the project level
-      and not in a submodule. If the bellow plugins are disabled (<phase>none</phase>), it's a workaround to
-      not generate ".jar" "-sources.jar" and "-javadoc.jar".
-      -->
       <plugin>
         <groupId>org.simplify4u.plugins</groupId>
         <artifactId>sign-maven-plugin</artifactId>
diff --git a/pom.xml b/pom.xml
index 4dac688a28d..5e25c72f229 100644
--- a/pom.xml
+++ b/pom.xml
@@ -99,6 +99,14 @@
     <version.jacoco.plugin>0.8.10</version.jacoco.plugin>
   </properties>
 
+  <distributionManagement>
+    <repository>
+      <id>local-folder</id>
+      <name>Local folder to test deployment configuration</name>
+      <url>file:./local-deployment</url>
+    </repository>
+  </distributionManagement>
+
   <dependencyManagement>
     <dependencies>
       <dependency>