From a39e170b23bd487352b613d58fe856f7c388d235 Mon Sep 17 00:00:00 2001
From: Johann Beleites <sdefend_9jftz8pq@esnail.de>
Date: Mon, 4 Mar 2024 17:56:32 +0100
Subject: [PATCH] SONARJAVA-4814 Improved S1948 RSPEC to better explain why
 public collections are a problem (#4698)

---
 .../resources/org/sonar/l10n/java/rules/java/S1948.html  | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S1948.html b/sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S1948.html
index b372f22c88e..9dc9caa5127 100644
--- a/sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S1948.html
+++ b/sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S1948.html
@@ -9,10 +9,11 @@ <h2>Why is this an issue?</h2>
 not exhibit unexpected behaviour when an instance is serialized.</p>
 <p>This rule raises an issue on:</p>
 <ul>
-  <li> non-<code>Serializable</code> fields, </li>
-  <li> collection fields when they are not <code>private</code> (because they could be assigned non-<code>Serializable</code> values externally),
-  </li>
-  <li> when a field is assigned a non-<code>Serializable</code> type within the class. </li>
+  <li> Non-<code>Serializable</code> fields. </li>
+  <li> When a field is assigned a non-<code>Serializable</code> type within the class. </li>
+  <li> Collection fields when they are not <code>private</code>. Values that are not serializable could be added to these collections externally. Due
+  to type erasure, it cannot be guaranteed that the collection will only contain serializable objects at runtime despite being declared as a
+  collection of serializable types. </li>
 </ul>
 <h2>How to fix it</h2>
 <p>Consider the following scenario.</p>