Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'View ...'s files' link go only to same dashboard-pane not displaying any new information. #294

Open
bourgeoa opened this issue Jun 7, 2021 · 1 comment

Comments

@bourgeoa
Copy link
Contributor

bourgeoa commented Jun 7, 2021

@timbl @SharonStrats
This is the consequence of commit 4cff4db

This is not a good idea because now you go to the same dashboard-pane and never display any content. The only way to get information is to click on folder icon.

Going to /public/ displays at least the /public/ in folder-pane.
This seems a user regression.

A solution could be first to reverse the commit and may be next to list in homepage.ts the root folder content as folder-pane as can be seen in https://files.gitter.im/54d55a83db8155e6700f8b7a/41mY/pod-root.png proposal from @jeff-zucker

But I don't know how to add the code to call and display a pane area containing a root folder-pane in https://github.com/solid/solid-panes/blob/main/src/dashboard/homepage.ts

@timbl
Copy link
Contributor

timbl commented Jun 8, 2021

To display a specific pane it is like

const pane = context.session.paneRegistry.byName('folder')
  or
const pane = panes.byName('folder')

const paneDiv = pane.render(subject, context, options)

@bourgeoa bourgeoa mentioned this issue Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants