Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When editing an existing, correct custom query, if the new query version is erroneous, the previous result stays on screen #137

Open
mvanbrab opened this issue Jun 26, 2024 · 2 comments
Assignees

Comments

@mvanbrab
Copy link
Collaborator

Example SPARQL query used in the correct custom query:

SELECT ?s ?p ?o WHERE {
  ?s ?p ?o
}

Example erroneous SPARQL query used in the update (mind the ?o2):

SELECT ?s ?p ?o2 WHERE {
  ?s ?p ?o
}

The updated result view shows an error at the bottom indeed, but the previous result table is still visible:

image

@EmilioTR
Copy link
Collaborator

I did not find an immediate cause for this issue. However, I have a solution in sight that will enhance the robustness of the query editor. We should implement a validation check when submitting a new or edited query to prevent submission if the query is faulty.

@mvanbrab
Copy link
Collaborator Author

The SPARQL query validation check is requested in #143.
Let's not use it to avoid the current issue.
We can use the current observation to understand why the displayed result table is out of sync, something that also happens randomly in other circumstances, where we see an old result that subsequently is updated with a new result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants