-n breaks when using IPs instead of hostnames

[cmprmsd]

When specifying one host or a list of hosts the share enumeration works fine and treewalker tasks get started.
When you use IPs instead of hostnames the shares get enumerated (Talking about SYSVOL and NETLOGON here) (-v debug shows the shares), but the [Share] output that confirms the read access does not show up and the treewalker tasks will not be not started.

I'm trying to understand the issue and provide a fix, but you have better knowledge of the code and might know the solution already. 😁

[cmprmsd]

For other Shares than SYSVOL and NETLOGON the [Share] green entry is listed also when passing an IP e.g.

[Share] Green   \\192.168.56.10\CertEnroll      R

For the call with ip and hostname I see the Treewalker creation when the share is not a SYSVOL or NETLOGON share:

[Trace] Creating a TreeWalker task for \\sevenkingdoms.local\CertEnroll
[Trace] Creating a TreeWalker task for \\192.168.56.10\CertEnroll

[cmprmsd]

I merged the Exception handling to output all Exceptions in IsShareReadable within ShareFinder.cs (not ShareClassifier.cs)
and noticed that I cannot access the SYSVOL and NETLOGON shares via IP and get an access denied.

[Trace] Unhandled exception in IsShareReadable() for share path: \\192.168.56.11\NETLOGON Full Exception:System.IO.IOException: Access Denied

I guess it is no Snaffler issue then but more some annoying "AD/DNS thing"... T_T

[cmprmsd]

yups...
I verified this with different new shares.
NETLOGON and SYSVOL both use DFS, which relies on DNS. So specifying IP addresses won't work.
Implementing a reverse resolver before checking the share access will help.

I added reverse DNS entries in hope that Windows and DFS will handle the reverse lookup itself but that seems not to be the case in my lab at least.

@l0ss What would you suggest on this problem? It only affects DFS shares, but an internal reverse lookup upfront for each target IP in -n's target list would be worth a try.