Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong grade #13

Open
SlothyCat opened this issue Nov 15, 2024 · 1 comment
Open

Wrong grade #13

SlothyCat opened this issue Nov 15, 2024 · 1 comment

Comments

@SlothyCat
Copy link
Owner

SlothyCat commented Nov 15, 2024

grade should be 0 - 100, it is -1 in the .json file

image.png

@soc-pe-bot
Copy link

soc-pe-bot commented Nov 18, 2024

Team's Response

The grade is assigned as -1 in the data file to signify that the module is currently ungraded. If we were to use 0 to signify an ungraded module, it will be a clash in value for a student that has gotten 0 for his grade.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: Hi team, thank you for the clarification that the grade was assigned to -1 to signify that the module is currently ungraded and using 0 will not be a good choice as it would mean the student had received 0 for this module. It makes sense but it may cause certain confusion for users that are editing the .json file directly.

While it is not an important issue to the current version as not everyone will edit the .json file directly, let's consider highlighting the fact that -1 will be for grades that are not yet assigned so that experienced users will understand the rationale for the -1 value.

We could include a note under this section in the user guide for better clarification in future iterations. Since this bug is no longer a functionality issue, it should be a documentation bug but I cannot seem to find a way to edit the bug type.

image.png

Screenshot 2024-11-19 at 12.15.48 PM.png


❓ Issue severity

Team chose [severity.VeryLow]
Originally [severity.Medium]

  • I disagree

Reason for disagreement: I understand that this bug does not occur frequently as not all users will edit the .json file directly, but it can be considered a rare situation and it causes minor confusion to the user when editing the grades. This fits in the description of a severity.Low bug as it causes minor inconvenience in rare situations without affecting the normal operations of the product.

image.png


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants