Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All applications use the same generated DLL #12

Open
Slion opened this issue Sep 1, 2023 · 5 comments
Open

All applications use the same generated DLL #12

Slion opened this issue Sep 1, 2023 · 5 comments
Labels
bug Something isn't working question Further information is requested

Comments

@Slion
Copy link
Owner

Slion commented Sep 1, 2023

All applications using VirtualDesktop use the same generated DLL from the app data folder.
We should store it on a path specific to the running application to avoid conflicts.

@Slion Slion added the bug Something isn't working label Sep 1, 2023
@Slion Slion changed the title Multiple applications using VirtualDesktop use the same generated DLL All applications use the same generated DLL Sep 1, 2023
@Slion
Copy link
Owner Author

Slion commented Sep 1, 2023

Actually I don't think this is true. It might already be working properly.

@Slion
Copy link
Owner Author

Slion commented Sep 1, 2023

This is definitely not an issue for packaged applications such as Taskbar where the generated assembly lands in such path:
C:\Users\micro\AppData\Local\Packages\Slions.TaskbarTest_aarv4tknj59mw\LocalCache\Local\slions.net\VirtualDesktop\assemblies

However I wonder if this could be an issue for non-packaged applications such as our demo sample where the generated assembly land in such path:
C:\Users\micro\AppData\Local\slions.net\VirtualDesktop\assemblies

@Slion Slion added the question Further information is requested label Sep 1, 2023
@mzomparelli
Copy link
Collaborator

I think you're right every app would use the same dll, why would there be conflicts?

Why not generate the DLL next to the existing one where the users exe is? That way each app has to generate their own.

@mzomparelli
Copy link
Collaborator

I'm afraid generating next to the existing dll might not be a good idea if the user wants to create a single exe with no attached dlls. The original dll can be injected into the exe but the generated dll would be exposed. Might not be so bad if it removed the generated dll when the app shutdown.

@mzomparelli
Copy link
Collaborator

I think it's fine the way it is and I don't think apps using the same dll will cause a conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants