-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All applications use the same generated DLL #12
Comments
Actually I don't think this is true. It might already be working properly. |
This is definitely not an issue for packaged applications such as Taskbar where the generated assembly lands in such path: However I wonder if this could be an issue for non-packaged applications such as our demo sample where the generated assembly land in such path: |
I think you're right every app would use the same dll, why would there be conflicts? Why not generate the DLL next to the existing one where the users exe is? That way each app has to generate their own. |
I'm afraid generating next to the existing dll might not be a good idea if the user wants to create a single exe with no attached dlls. The original dll can be injected into the exe but the generated dll would be exposed. Might not be so bad if it removed the generated dll when the app shutdown. |
I think it's fine the way it is and I don't think apps using the same dll will cause a conflict. |
All applications using VirtualDesktop use the same generated DLL from the app data folder.
We should store it on a path specific to the running application to avoid conflicts.
The text was updated successfully, but these errors were encountered: