Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add support for brewing brews #30

Open
TomLewis opened this issue Apr 25, 2023 · 5 comments
Open

Suggestion: Add support for brewing brews #30

TomLewis opened this issue Apr 25, 2023 · 5 comments

Comments

@TomLewis
Copy link

Add support for Brews made in https://www.spigotmc.org/resources/brewery.3082/
It could be as simple as listing brewingIDs under the cooldown type.

exampleBrewing:
  cooldown: 30
  cooldown-type: POTION_THROW
  brewingIDs:
    - 123
    - 124
  amount: 2
  reset-amount: true
@CarissaCoding
Copy link

CarissaCoding commented Feb 22, 2024

Hey @TomLewis,

Hope you're doing well! We're all in for adding support for Brewery's brews to our plugin. To make sure we nail the integration, could you shoot over the custom brewing jar file you're using to my email [email protected]? It'll give us the lowdown on what we're working with and help us get this feature up and running smoothly. I think we should be able to directly integrate it for you if its urgent in a couple of days time.

Thanks a bunch for your help on this one. Looking forward to diving in and making this happen and sorry for the delay!

Cheers,

Carissa

@TomLewis
Copy link
Author

Im not using a custom brewing jar! im using the one from the Spigot page! This is fantastic you are going to add cooldowns, it will be much appriciated!

@CarissaCoding
Copy link

Im not using a custom brewing jar! im using the one from the Spigot page! This is fantastic you are going to add cooldowns, it will be much appriciated!

Hi @TomLewis!

Sorry I did not explain myself correctly earlier, I don't mean to say you're using a modified version of the plugin, thats my bad! I meant to say if you could send the brewery pluggin with however you've customized it (changed milk strength effects, added custom recipes etc) as it would be really helpful to troubleshoot it and find any bugs it might have, and we'll work on releasing a public version with this sometime in the future.

Thanks!
Carissa

@TomLewis
Copy link
Author

TomLewis commented Mar 1, 2024

You'll be fine with the vanilla examples, all the additional brews created are just copies of the example brews teeaked!

@SirBlobman
Copy link
Owner

@TomLewis Apologies, didn't see this. Not sure why that account is trying to send messages on my behalf as I do not know them personally. I'll look into adding support in a future update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants