Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning CS0618 Obsolete function overload NSUrlSession.FromConfiguration #97

Open
1 task
runesig opened this issue Nov 1, 2018 · 1 comment
Open
1 task

Comments

@runesig
Copy link

runesig commented Nov 1, 2018

When I am trying to compile this for iOS I get a warning:

Warning CS0618: 'NSUrlSession.FromConfiguration(NSUrlSessionConfiguration, NSUrlSession Delegate, NSOperationQueue)' is obsolete: 'Use the overload with a 'INSUrlSessionDelegate' parameter.'

The issue is in the file DownloadManagerImplementation.cs for iOS and the function is "createSession":

    private NSUrlSession createSession(NSUrlSessionConfiguration configuration, UrlSessionDownloadDelegate sessionDownloadDelegate) {
        configuration.HttpMaximumConnectionsPerHost = 1;

        return NSUrlSession.FromConfiguration(configuration, sessionDownloadDelegate, null);
    }

Platform:

  • iOS
@SimonSimCity
Copy link
Owner

@runesig would you have the time to write a PR for this? 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants