About resolvePublicPath

[pigchao]

hi ,

is there some problem when call function util.resolvePublicPath with publicPath is undefined,

it doesn't return the relative path from the html template;

`function resolvePublicPath(compilation, filename) {
/* istanbul ignore else */
const publicPath =
typeof compilation.options.output.publicPath !== 'undefined'
? compilation.options.output.publicPath
: _path().default.relative(_path().default.dirname(filename), '.'); // TODO: How to test this? I haven't written this logic, unsure what it does

return ensureTrailingSlash(publicPath);
}`

change to

`function resolvePublicPath(compilation, filename, childCompilationOutputName) {

//Copied from html-webpack-plugin
var publicPath =
typeof compilation.options.output.publicPath !== 'undefined'
? compilation.options.output.publicPath
: _path().default.relative(_path().default.resolve(compilation.options.output.path, _path().default.dirname(childCompilationOutputName)), compilation.options.output.path)
.split(_path().default.sep).join('/');

return ensureTrailingSlash(publicPath);
}
`

will compile the correct relative path

childCompilationOutputName = htmlPluginData.outputName

[SimenB]

Would you mind sending a PR to fix that? 🙂

Code:

add-asset-html-webpack-plugin/src/utils.js

Lines 12 to 21 in 6f74d9c

	// Copied from html-webpack-plugin
	export function resolvePublicPath(compilation, filename) {
	/* istanbul ignore else */
	const publicPath =
	typeof compilation.options.output.publicPath !== 'undefined'
	? compilation.options.output.publicPath
	: path.relative(path.dirname(filename), '.'); // TODO: How to test this? I haven't written this logic, unsure what it does
	return ensureTrailingSlash(publicPath);
	}