Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop of logout command if session is expired #20

Open
rkovarik opened this issue Sep 7, 2015 · 2 comments
Open

Infinite loop of logout command if session is expired #20

rkovarik opened this issue Sep 7, 2015 · 2 comments

Comments

@rkovarik
Copy link
Contributor

rkovarik commented Sep 7, 2015

No description provided.

rkovarik added a commit to rkovarik/engage-api-client that referenced this issue Sep 7, 2015
@rkovarik
Silverpop#20 don't reexecute logout command when session is expired t…
237d5b6 
…o prevent infinite loop
rkovarik added a commit to rkovarik/engage-api-client that referenced this issue Sep 7, 2015
@rkovarik
Silverpop#20 don't reexecute logout command when session is expired t…
96078e9 
…o prevent infinite loop
rkovarik added a commit to rkovarik/engage-api-client that referenced this issue Sep 11, 2015
@rkovarik
Silverpop#20 remove the surefire plugin and the test
418ef1b
rkovarik added a commit to rkovarik/engage-api-client that referenced this issue Sep 11, 2015
@rkovarik
Silverpop#20 remove the surefire plugin and the test
b832a90
@ergin-a1
Copy link

Can someone please merge the fixes or provide update about this?
IMHO, this is a high priority bug and makes the whole code unusable.
I am also open to other workaround to overcome this issue temporarily.

@ChrisCurtin
Copy link
Collaborator

@ergin-a1

Hi Ergin,

We've not done any work on this in quite a while. Looking through the pulls that we didn't accept last time we did, I don't see one that only had this fix it in so it won't be a simple accept of an existing pull.

It looks like rkovarik had the right idea here:
rkovarik@237d5b6

If you want to fork develop, add this and run a test then submit a pull with just that change I'll see who can help test it and accept it.

Thanks

Chris

ergin-a1 added a commit to Agilone/engage-api-client that referenced this issue Mar 23, 2017
@ergin-a1
AGO-8289 | Fixes infinite loop when session is expired Silverpop#20
95f081a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ergin-a1 @ChrisCurtin @rkovarik