[BUG] <title>./launcher.sh: line 246: cd: SillyTavern: No such file or directory</title>

[LO7O7]

Environment

🐧 Linux

System

OS : EndeavourOS x86_64 ;; Kernel : Linux 6.10.2-arch1-1 ;; WM : Hyprland (Wayland)

Describe the problem

After doing sh ./launcher.sh and selecting 1) start silly tavern
1️⃣ Minor issue :- the menu reappears again but it doesn't throw any error
2️⃣ Major issue :- after selecting 1) start silly tavern it throws the error ./launcher.sh: line 246: cd: SillyTavern: No such file or directory while it should start the start_sh function to start the shell script. BTW manually starting the start.sh script allows ST to run just fine.

Additional info

Please tick the boxes

• I have explained the issue clearly, and I included all relevant info
• I have checked that this issue hasn't already been raised
• I have checked the docs

[BruhDudeWew]

So after running bash -x, I've found out where it failed:

1. The find_terminal() function doesn't work. It just returned x-terminal-emulator which I (and maybe you too doesn't have). I just make the function to return "konsole" since that's what I used and it worked.
2. When it failed to launch due to missing x-terminal-emulator and you got thrown back to menu, the shell is still in the SillyTavern folder. That's why when it tried to cd back into SillyTavern again, it can't because it's already there.

I hope this help

[PopCat19]

So after running bash -x, I've found out where it failed:

1. The find_terminal() function doesn't work. It just returned x-terminal-emulator which I (and maybe you too doesn't have). I just make the function to return "konsole" since that's what I used and it worked.

2. When it failed to launch due to missing x-terminal-emulator and you got thrown back to menu, the shell is still in the SillyTavern folder. That's why when it tried to cd back into SillyTavern again, it can't because it's already there.

I hope this help

So replacing x-terminal-emulator with any terminal (e.g. konsole, alacritty, kitty, etc) should temporarily fix the issue.

# Function to find a suitable terminal emulator
find_terminal()
{
    for term in "$TERM"
    do
        if command -v "$term" > /dev/null 2>&1; then
            echo "$term"
            return 0
        fi
    done
    for terminal in "$TERMINAL"
    do
        if command -v "$terminal" > /dev/null 2>&1; then
            echo "$terminal"
            return 0
        fi
    done
    # Return a default terminal if none is found
    echo "x-terminal-emulator" # <-- Replace `x-terminal-emulator` with your terminal emulator
    return 1
}

They should at least add an input field (e.g. 'What terminal would you like <program/cmd> to use? ') instead of x-terminal-emulator.