Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different perspectives also visible for video's with NME #1409

Open
uklomp opened this issue Dec 3, 2024 · 9 comments
Open

Different perspectives also visible for video's with NME #1409

uklomp opened this issue Dec 3, 2024 · 9 comments

Comments

@uklomp
Copy link
Collaborator

uklomp commented Dec 3, 2024

Would it be possible to apply our new functionalities of the neutral gloss videos also to the videos uplaoded in the non-manual elements panel? That is: different perspectives, play, full screen etc.

@susanodd
Copy link
Collaborator

susanodd commented Dec 3, 2024

Are you asking to be able to upload three videos for each of the NME ?
(They have numbers on them, but that is just the order of display. You want 3 for each? (As opposed to displaying the already uploaded ones as alternatives?)
(Or do you want them displayed on top of each other with the numbers on top, to switch between?)

@uklomp
Copy link
Collaborator Author

uklomp commented Dec 3, 2024

For every sign that will be uploaded for NME, for which we agreed it will be minimum 1 and maximum 3, we want to be able to show different perspectives - just like with the neutral gloss video. So camera left and right etc.

@susanodd
Copy link
Collaborator

susanodd commented Dec 4, 2024

I'll let @Woseseltops do this. He did the API for the perspective video upload.

I'm not sure yet of how to properly name the new files. Also a new model class is needed. Maybe a subclass of both Perspective and NME videos.

@Woseseltops
Copy link
Collaborator

Woseseltops commented Dec 13, 2024

Functional design (mockup)

I think we need an extra dropdown during entry

image

And if there are multiple videos with the same index, but different perspectives, it won't show up like this:

image

but like this

image

Let me know if you disagree @uklomp !

@Woseseltops
Copy link
Collaborator

Woseseltops commented Dec 13, 2024

Technical design

  1. Add a perspective field to GlossVideoNME, reusing PERSPECTIVE_CHOICES
  2. Dropdown in the UI, processed and saved in the GlossVideoNME
  3. Change logic for the index counter: only increase if there already is a video with the same perspective
  4. On display, detect which videos belong together, show the perspective interface.

@susanodd
Copy link
Collaborator

susanodd commented Dec 13, 2024

@Woseseltops any preference for the filenames of the perspective NME videos?

_nme_N_left ?

@Woseseltops
Copy link
Collaborator

No preference, as long as we're consistent. Your question makes me think you might want to implement this one. If so, make yourself assignee! If not, I'll make a start this afternoon

@susanodd
Copy link
Collaborator

susanodd commented Dec 13, 2024

No preference, as long as we're consistent. Your question makes me think you might want to implement this one. If so, make yourself assignee! If not, I'll make a start this afternoon

I was thinking of the file system, since I was kind of very busy with it the past weeks.

You basically invented the migration with your mock-up :)

Just add the field perspective to class GlossVideoNME and have the default be ''.
Then all the existing video objects get migrated and are fine. Yes, it needs the _left after the _nme_N part.

You are also welcome to do it! It just needs the migration first, before any new things can be made.

Then modification to the generation of the file names is needed as well. (Where it is explicitly coded.) That would get a head start on the API.

i know how to implement it now. But you may begin if you want. Or at least browse the code in videos to see if it is too much to complete in your time today. The migration needs to be added first. Then the other code can be done in different branches once that is there. (We did this long ago with the Frequency data. I was afraid to make migrations in those days.)

I'm busy fixing the mess with the selected datasets at the moment. (Bug repair.)

@Woseseltops
Copy link
Collaborator

To do:

  • Merge master, fix conflicts
  • Use the perspective video player if applicable
  • Investigate video file names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants