Update dev-session graphql queries #4863
Merged
+24
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacroldan
changed the title
|
We detected some changes at packages/*/src and there are no updates in the .changeset. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1942 tests passing in 884 suites. Report generated by 🧪jest coverage report action from 1cce8f4 |
shauns
reviewed
Nov 15, 2024
| @@ -2,6 +2,9 @@ mutation DevSessionCreate($appId: String!, $assetsUrl: String!) { | |||
| devSessionCreate(appId: $appId, assetsUrl: $assetsUrl) { | |||
| userErrors { | |||
| message | |||
| on | |||
There was a problem hiding this comment.
I won't block the CLI PR but on is a keyword in GraphQL, we should consider a different name for this field. It should still work though
There was a problem hiding this comment.
shauns
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Part of a feature to improve errors in dev-sessions
WHAT is this pull request doing?
Adds additional error fields (
on,field, andcategory) to dev session GraphQL mutations to provide more detailed error information when creating or updating dev sessions.How to test your changes?
Measuring impact
Checklist