Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shells-go doesn't seem to use http_proxy #1

Open
ailisp opened this issue Oct 13, 2021 · 4 comments
Open

Shells-go doesn't seem to use http_proxy #1

ailisp opened this issue Oct 13, 2021 · 4 comments

Comments

@ailisp
Copy link

ailisp commented Oct 13, 2021

I need a proxy server to access shells.com, otherwise it['s extremely slow. When access my shell instance from browser, it take advantage of browser's proxy server setting so the speed is okay. However when use shells-go client, it become extremely slow again, similar to browser with proxy off. I suspect shells-go doesn't read http_proxy env var and use that as proxy

@MagicalTux
Copy link
Contributor

It should be possible to honor http_proxy if found, but might not work in all cases since we'd use CONNECT method

@MagicalTux
Copy link
Contributor

Latest version pushed v0.2.3 should honor https_proxy as long as it's a HTTP proxy. Socks support isn't implemented for now.

@ailisp
Copy link
Author

ailisp commented Feb 18, 2022

I deleted the old shells-go, get a new one by go get. But it crashed after i clicked on my subscription. with following log:

~ echo $http_proxy
http://localhost:8889
~ echo $https_proxy
http://localhost:8889
~ shells-go
2022/02/18 14:55:03 Initializing PortAudio version PortAudio V19.6.0-devel, revision 396fe4b6699ae929d3a685b3ef8a7e97396139a4
ALSA lib pcm.c:2642:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.rear
ALSA lib pcm.c:2642:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.center_lfe
ALSA lib pcm.c:2642:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.side
ALSA lib pcm_route.c:869:(find_matching_chmap) Found no matching channel map
ALSA lib pcm_route.c:869:(find_matching_chmap) Found no matching channel map
ALSA lib pcm_route.c:869:(find_matching_chmap) Found no matching channel map
ALSA lib pcm_route.c:869:(find_matching_chmap) Found no matching channel map
ALSA lib pcm_oss.c:377:(_snd_pcm_oss_open) Unknown field port
ALSA lib pcm_oss.c:377:(_snd_pcm_oss_open) Unknown field port
ALSA lib pcm_usb_stream.c:486:(_snd_pcm_usb_stream_open) Invalid type for card
ALSA lib pcm_usb_stream.c:486:(_snd_pcm_usb_stream_open) Invalid type for card
2022/02/18 14:55:03 default output device: default type ALSA
2022/02/18 14:55:03 login: found saved token
2022/02/18 14:55:05 [rest] Token has expired, requesting renew
2022/02/18 14:55:05 [rest] POST OAuth2:token => 729.489644ms
2022/02/18 14:55:06 [rest] GET Shell => 3.012730732s
2022/02/18 14:55:08 [rest] POST Shell/shell-7uzpkr-32qb-er7a-vo2u-k677iz54:spice => 991.118426ms
2022/02/18 14:55:08 got spice = {Host:la01-10.shellsnet.com ID:shell-7uzpkr-32qb-er7a-vo2u-k677iz54 Key:JK9HaMyPtzYBHl5aqfG35J0vXivSNpSo Password:<...> Port:443 Protocol:wss Token:<...> URL:wss://la01-10.shellsnet.com/websockify/destInfoToken/<...>/type/raw}
2022/02/18 14:55:08 rdp: attempting connection on port 3389 ...
2022/02/18 14:55:08 rdp: failed to connect to port 3389, giving up
2022/02/18 14:55:09 spice init failed: failed to establish shl-spice

(in precious version, it did not utilize the proxy and extremely slow. The proxy guarantees to work because when use browser with the same proxy to access shells remote machine, it's fast)

@MagicalTux
Copy link
Contributor

Just modified code in 2031713 so it performs the handshake during the connection, can you retry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants