Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the frontend to use generic RPC_URL instead of INFURA_ID for ENS Resolution #484

Open
apbendi opened this issue Apr 4, 2023 · 0 comments
Assignees
Labels
app A change related to the Umbra frontend enhancement New feature or request library A change related to the umbra-js library

Comments

@apbendi
Copy link
Member

apbendi commented Apr 4, 2023

Currently, we use the INFURA_ID env var to get a provider in a number of places in the frontend. We want to move toward using a generic RPC_URL environment variable that can be used with any provider.

The INFURA_ID env var is currently used for a number of tasks, including ENS and CNS name resolution, checking for contract code, and as a fallback when the user's wallet provider rejects the transactions from accounts not associated with that user's wallet. It is used in both the frontend and the umbra-js subrepos.

We do not need to convert all of these over to a generic RPC_URL at once. For example, it would be useful to move in-app ENS Resolution only at first, so we could split the load across providers, and continue the refactor after that.

@apbendi apbendi added enhancement New feature or request app A change related to the Umbra frontend library A change related to the umbra-js library labels Apr 4, 2023
@apbendi apbendi added this to Umbra Apr 4, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Umbra Apr 4, 2023
@apbendi apbendi moved this from 🆕 New to To do in Umbra Apr 4, 2023
@garyghayrat garyghayrat moved this from To do to In progress in Umbra Dec 14, 2023
@jferas jferas moved this from In progress to 👀 In review in Umbra Jan 22, 2024
@jferas jferas moved this from 👀 In review to ✅ Done in Umbra Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app A change related to the Umbra frontend enhancement New feature or request library A change related to the umbra-js library
Projects
Status: Done
Development

No branches or pull requests

2 participants