Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AbstractProblemType #548

Closed
wants to merge 1 commit into from
Closed

add AbstractProblemType #548

wants to merge 1 commit into from

Conversation

prbzrg
Copy link
Member

@prbzrg prbzrg commented Nov 30, 2023

Fixes #482

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • [no need?] All documentation related to code changes were updated
  • The new code follows the contributor guidelines, in particular the ScioML Style Guide and COLPRAC.
  • [no need?] Any new documentation only uses public API

Additional context

lots of changes caused by applying JuliaFormatter.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (3db3a3a) 41.85% compared to head (54d33c0) 41.85%.

Files Patch % Lines
src/ensemble/basic_ensemble_solve.jl 23.52% 13 Missing ⚠️
src/function_wrappers.jl 0.00% 6 Missing ⚠️
src/problems/basic_problems.jl 50.00% 4 Missing ⚠️
ext/SciMLBaseZygoteExt.jl 0.00% 3 Missing ⚠️
src/problems/sde_problems.jl 0.00% 2 Missing ⚠️
src/scimlfunctions.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #548      +/-   ##
==========================================
- Coverage   41.85%   41.85%   -0.01%     
==========================================
  Files          53       53              
  Lines        4155     4160       +5     
==========================================
+ Hits         1739     1741       +2     
- Misses       2416     2419       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prbzrg
Copy link
Member Author

prbzrg commented Apr 26, 2024

This PR got too much change and conflict.

@prbzrg prbzrg closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant