Skip to content
This repository has been archived by the owner on Sep 28, 2024. It is now read-only.

Mutli-dimensional input-grid for DeepONet #73

Open
dynamic-queries opened this issue Jun 24, 2022 · 4 comments
Open

Mutli-dimensional input-grid for DeepONet #73

dynamic-queries opened this issue Jun 24, 2022 · 4 comments

Comments

@dynamic-queries
Copy link

In https://github.com/SciML/NeuralOperators.jl/blob/master/src/DeepONet.jl#L122-L124, multi-dimensional input grid is handled using an Argument error. Is there a reason this was done this way?

Also, if it is a matter of contracting AbstractArray(s), we could look into OMEinsum.jl for its implemention.

Please advise.

@yuehhua
Copy link
Collaborator

yuehhua commented Jun 26, 2022

multi-dimensional input grid is handled using an Argument error. Is there a reason this was done this way?

@Abhishek-1Bhatt Any ideas?

For contracting AbstractArray(s), this package uses Tullio.jl for it. Should work.

@dynamic-queries
Copy link
Author

If this is still unresolved. I have a quick fix with OMEinsum.jl
Should I open a PR?

@ChrisRackauckas
Copy link
Member

Could you try setting it up with Tullio? That should make it easier for making it support GPUs.

@yuehhua
Copy link
Collaborator

yuehhua commented Jun 30, 2022

It is welcome to support multi-dimensional input for DeepONet. However, it will be nice to use Tullio to make deps simple.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants