-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with SIUnits.jl #34
Comments
Adaptive units now work. |
I got the plot recipes working. I'll be adding this to master soon. |
SIUnits now work with all ODE functions. Not with SDE because the natural timescale is sqrt(t) for Brownian motion, and SIUnits don't support rational units (or sqrt). PDEs don't work because sparse multiplication is borked with units, and I started discussions to support Unitful as well. Since only two functions ( |
Compatibility with SIUnits.jl is almost complete. This is on the units branch. For example, it works with ODEs and SDEs:
Works. What doesn't work is if you use
alg=:ExplicitRK
. That's the only DifferentialEquation.jl alg solver that doesn't work, but there is an open issue to fix that: Keno/SIUnits.jl#85.The other problem is the plotting. Currently you have to do:
To make it simpler for users, plot recipes will need to be defined. The issue is open for that: Keno/SIUnits.jl#86.
Problems exist with UnitRanges, so meshgrid doesn't work:
and Heat Equation needs more work (A needs units).
The text was updated successfully, but these errors were encountered: