Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer assume that prob.p is the correct parameters for a problem lacking callbacks and DAEs #1087

Open
isaacsas opened this issue Oct 24, 2024 · 2 comments
Labels

Comments

@isaacsas
Copy link
Member

Per the discussion in SciML/ModelingToolkit.jl#2733 parameters may not always get updated for non-DAE models anymore until integrator initialization. We should therefore no longer assume prob.p are updated and correct parameters associated with the prob. I think this is a potential issue in some of the extensions that needs to be checked and updated.

@isaacsas isaacsas added the bug label Oct 24, 2024
@isaacsas
Copy link
Member Author

This probably impacts tests in a number of places too.

@ChrisRackauckas
Copy link
Member

Just to be clear, "no longer" - this change happened in 2017. It is for example a very essential feature in Pumas that parameters are updated in the callback initialization, which can do all sorts of things like add tstops the user may have forgotten https://github.com/SciML/DiffEqCallbacks.jl/blob/master/src/iterative_and_periodic.jl#L163-L169, project the initial state (and all subsequent states) onto a manifold https://github.com/SciML/DiffEqCallbacks.jl/blob/master/src/manifold.jl#L118-L139, etc. So it could not necessarily be assumed even before Catalyst was created.

@isaacsas isaacsas changed the title no longer assume that prob.p is the actual correct and updated parameters for a problem no longer assume that prob.p is the correct parameters for a problem lacking callbacks and DAEs Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants