Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorise design #4814

Open
4 tasks done
s-steddy opened this issue Feb 9, 2023 · 3 comments
Open
4 tasks done

Categorise design #4814

s-steddy opened this issue Feb 9, 2023 · 3 comments
Assignees
Labels

Comments

@s-steddy
Copy link

s-steddy commented Feb 9, 2023

To align the new Categorise on mobile with desktop, let's compare:

image

image

  • Slight redesign from @GhadaShebl needed - consistent colours (no blue), rounded corners, etc. I think the dotted line box saying 'drag answers here' could be expanded to take up the whole space as it currently does on desktop
  • Get rid of the bumps under the answers that can be seen in the review round.

I think these have already been done:

  • Centre category headings
  • Expand categories after all answers have been sorted.
@s-steddy s-steddy changed the title Categorise to work by swapping Categorise design and swapping Feb 9, 2023
@s-steddy s-steddy changed the title Categorise design and swapping Categorise design Feb 9, 2023
@s-steddy s-steddy added the Mobile label Feb 9, 2023
@GhadaShebl
Copy link

@s-steddy
Copy link
Author

s-steddy commented Feb 28, 2023

Much closer to desktop now so we're making progress but a few things have become apparent as I'm playing:

  • Answers need to be completely non-interactible like we've just made for Vertical Shuffle. This is text, make sure images aren't copyable either, etc. (Second image is after holding on image).

image

image

  • Remove these white bars on the left of images in answers:

image

image

And here's why we need to keep thinking about design. It's possible for categories and answers to be pushed too far down the page. I think this is ok for answers, in this image the category zero is below the bottom of the screen:
image

But if I scroll down to see the category, I can't see the answers any more:
image

  • I think if scrolling down, answers need to stay visible in column on the right. Can that be done?

ivanromakh added a commit that referenced this issue Mar 1, 2023
@ivanromakh
Copy link
Collaborator

not sure about last one. it look complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants