Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark unrecoverable payjoin sessions in storage so they don't spawn #410

Open
DanGould opened this issue Dec 31, 2024 · 0 comments
Open

Mark unrecoverable payjoin sessions in storage so they don't spawn #410

DanGould opened this issue Dec 31, 2024 · 0 comments

Comments

@DanGould
Copy link
Contributor

We mark successful payjoins so that they don't spawn more isolates (#400)

A similar approach will prevent so many isolates for spawning in the case of

  • Unrecoverable errors
  • Expired payjoins

However, error handling in payjoin-flutter and even to some extent rust-payjoin is incomplete.

I can start with a broad brush and mark entire error variants produced by payjoin-flutter as unrecoverable in storage, knowing that the underlying library will change as our error propagation becomes more robust. This is acknowledged tech debt. I'm going to try to balance fixing the problem in the short term without complete engineering, because I know it's going to need to change as soon as the library updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant